squall/cutlass
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix sign-compare warning in reorder_array (#869)

Browse Source 
`std::vector<T>::size_type` is unsigned type, so let's iterate over unsigned type as well


Discovered, while trying to enable PyTorch building without `-Wno-sign-compare` warning suppression, see https://github.com/pytorch/pytorch/actions/runs/4418987999/jobs/7746850762#step:10:10532
This commit is contained in:
Nikita Shulga 2023-03-20 14:07:24 -07:00 committed by GitHub
parent af332d4aa9
commit 2670b973dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/cutlass/gemm/device/base_grouped.h
View File

@ -157,7 +157,7 @@ private:
static void reorder_array(T* data, const std::vector<size_t>& indices) {
// For now, simply create a copy of the data and then copy over to the original.
std::vector<T> copy(indices.size());
for (int i = 0; i < indices.size(); ++i) {
for (unsigned i = 0; i < indices.size(); ++i) {
copy.at(i) = data[indices[i]];
}