squall/cutlass
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove undefined behavior from default constructor of PredicatedTileAccessIteratorParams. (#1258)

Browse Source 
Currently, the default constructor of
`PredicatedTileAccessIteratorParams` will invoke undefined behavior in
its invocation of the `initialize` function. Specifically, it will
attempt to read from the uninitialized variables
`desc.element_size_bits` and `desc.advance_rank`. This commit changes
the default constructors of both `*Params` and `*Desc` to
zero-initialize all uninitialized members.
This commit is contained in:
Gregory Meyer (gregjm) 2023-12-11 20:01:53 -08:00 committed by GitHub
parent 30ec1a4649
commit f60786b536
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
include/cutlass/transform/threadblock/predicated_tile_access_iterator_params.h
View File

@ -46,6 +46,7 @@
#include "cutlass/cutlass.h"
#include "cutlass/array.h"
#include "cutlass/detail/helper_macros.hpp"
#include "cutlass/layout/matrix.h"
#include "cutlass/layout/pitch_linear.h"
@ -60,8 +61,8 @@ namespace threadblock {
/// Predicated tile access iterator descriptor object containing template dependent state
struct PredicatedTileAccessIteratorDesc {
int element_size_bits;
int advance_rank;
int element_size_bits = -1;
int advance_rank = -1;
layout::PitchLinearCoord threadblock_shape;
layout::PitchLinearCoord threadmap_iterations;
layout::PitchLinearCoord threadmap_delta;
@ -71,7 +72,7 @@ struct PredicatedTileAccessIteratorDesc {
//
CUTLASS_HOST_DEVICE
PredicatedTileAccessIteratorDesc() { }
PredicatedTileAccessIteratorDesc() = default;
CUTLASS_HOST_DEVICE
PredicatedTileAccessIteratorDesc(
@ -232,16 +233,16 @@ struct PredicatedTileAccessIteratorParams {
// Data members
//
/// stride of pitch-linear layout (units of Element)
LongIndex stride_;
LongIndex stride_ = 0;
/// amount (in byte) to increment pointer to move to next access along
/// strided dimension
LongIndex inc_strided_;
LongIndex inc_strided_ = 0;
/// amount (in byte) to increment pointer from last access to first access
/// of next tile
LongIndex inc_next_;
LongIndex inc_next_ = 0;
/// amount (in byte) to increment pointer from first access of current tile
/// to first access of next tile
LongIndex inc_advance_;
LongIndex inc_advance_ = 0;
//
// Methods
@ -249,6 +250,8 @@ struct PredicatedTileAccessIteratorParams {
CUTLASS_HOST_DEVICE
Status initialize(LongIndex stride, PredicatedTileAccessIteratorDesc desc) {
CUTLASS_ASSERT(desc.element_size_bits > 0);
CUTLASS_ASSERT(desc.advance_rank == 0 || desc.advance_rank == 1);
stride_ = stride;
@ -277,9 +280,7 @@ struct PredicatedTileAccessIteratorParams {
}
CUTLASS_HOST_DEVICE
PredicatedTileAccessIteratorParams() {
initialize(LongIndex(0), PredicatedTileAccessIteratorDesc());
}
PredicatedTileAccessIteratorParams() = default;
CUTLASS_HOST_DEVICE
PredicatedTileAccessIteratorParams(Index stride, PredicatedTileAccessIteratorDesc desc) {