From c74c913bfbefc5d7a1302557eb35cdcbecd91f67 Mon Sep 17 00:00:00 2001 From: SangBin Cho Date: Wed, 22 May 2024 22:02:58 +0900 Subject: [PATCH] [misc] remove comments that were supposed to be removed (#4977) --- tests/lora/conftest.py | 1 - vllm/lora/models.py | 2 -- 2 files changed, 3 deletions(-) diff --git a/tests/lora/conftest.py b/tests/lora/conftest.py index 95fc65cd..e5cf9cd4 100644 --- a/tests/lora/conftest.py +++ b/tests/lora/conftest.py @@ -185,7 +185,6 @@ def long_context_lora_files_32k(): return snapshot_download(repo_id="SangBinCho/long_context_32k_testing") -# SANG-TODO Download long lora files. @pytest.fixture(scope="session") def long_context_infos(long_context_lora_files_16k_1, long_context_lora_files_16k_2, diff --git a/vllm/lora/models.py b/vllm/lora/models.py index d001d171..a2092d31 100644 --- a/vllm/lora/models.py +++ b/vllm/lora/models.py @@ -105,8 +105,6 @@ def convert_mapping( lora_offset: int = long_lora_context.offsets_by_lora_id.get( index_mapping_indices[i], 0) long_lora_offsets[i] = lora_offset - # SANG-TODO - # index_mapping_indices[i] = i indices_list: List[Union[List[int], torch.Tensor]] = [ index_mapping_indices, lora_indices, embedding_indices