[TPU] Align worker index with node boundary (#7932)
This commit is contained in:
parent
e6a26ed037
commit
e2b2aa5a0f
@ -111,12 +111,40 @@ class RayTPUExecutor(TPUExecutor):
|
|||||||
# Else, added to the list of workers.
|
# Else, added to the list of workers.
|
||||||
self.workers.append(worker)
|
self.workers.append(worker)
|
||||||
|
|
||||||
|
logger.debug("workers: %s", self.workers)
|
||||||
|
logger.debug("driver_dummy_worker: %s", self.driver_dummy_worker)
|
||||||
if self.driver_dummy_worker is None:
|
if self.driver_dummy_worker is None:
|
||||||
raise ValueError(
|
raise ValueError(
|
||||||
"Ray does not allocate any TPUs on the driver node. Consider "
|
"Ray does not allocate any TPUs on the driver node. Consider "
|
||||||
"adjusting the Ray placement group or running the driver on a "
|
"adjusting the Ray placement group or running the driver on a "
|
||||||
"TPU node.")
|
"TPU node.")
|
||||||
|
|
||||||
|
worker_ips = [
|
||||||
|
ray.get(worker.get_node_ip.remote()) # type: ignore[attr-defined]
|
||||||
|
for worker in self.workers
|
||||||
|
]
|
||||||
|
ip_counts: Dict[str, int] = {}
|
||||||
|
for ip in worker_ips:
|
||||||
|
ip_counts[ip] = ip_counts.get(ip, 0) + 1
|
||||||
|
|
||||||
|
def sort_by_driver_then_worker_ip(worker):
|
||||||
|
"""
|
||||||
|
Sort the workers based on 3 properties:
|
||||||
|
1. If the worker is on the same node as the driver (vllm engine),
|
||||||
|
it should be placed first.
|
||||||
|
2. Then, if the worker is on a node with fewer workers, it should
|
||||||
|
be placed first.
|
||||||
|
3. Finally, if the work is on a node with smaller IP address, it
|
||||||
|
should be placed first.
|
||||||
|
"""
|
||||||
|
ip = ray.get(worker.get_node_ip.remote())
|
||||||
|
return (ip != driver_ip, ip_counts[ip], ip)
|
||||||
|
|
||||||
|
# After sorting, the workers on the same node will be
|
||||||
|
# close to each other, and the workers on the driver
|
||||||
|
# node will be placed first.
|
||||||
|
self.workers = sorted(self.workers, key=sort_by_driver_then_worker_ip)
|
||||||
|
|
||||||
# Get the set of TPU IDs used on each node.
|
# Get the set of TPU IDs used on each node.
|
||||||
worker_node_and_gpu_ids = self._run_workers("get_node_and_gpu_ids",
|
worker_node_and_gpu_ids = self._run_workers("get_node_and_gpu_ids",
|
||||||
use_dummy_driver=True)
|
use_dummy_driver=True)
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user