From eb6c50cdc2bfb58591bd524ff08c8016e7c0411a Mon Sep 17 00:00:00 2001 From: Cyrus Leung Date: Thu, 30 May 2024 07:02:54 +0800 Subject: [PATCH] [Bugfix][CI/Build] Fix codespell failing to skip files in `git diff` (#5097) --- format.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/format.sh b/format.sh index aaec25a8..d110855f 100755 --- a/format.sh +++ b/format.sh @@ -113,8 +113,11 @@ mypy vllm/logging --config-file pyproject.toml mypy vllm/model_executor --config-file pyproject.toml +# If git diff returns a file that is in the skip list, the file may be checked anyway: +# https://github.com/codespell-project/codespell/issues/1915 +# Avoiding the "./" prefix and using "/**" globs for directories appears to solve the problem CODESPELL_EXCLUDES=( - '--skip' '*docs/source/_build/**,./tests/lora/data' + '--skip' 'tests/prompts/**,./benchmarks/sonnet.txt,tests/lora/data/**,build/**' ) # check spelling of specified files